Port to web #1263
Merged
Port to web #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
github-actions
bot
added
A-Core
A-Engine
B-Build
|
luishfonseca
force-pushed
the
465-port-to-web
branch
3 times, most recently
from
1354f0b to
64a4c62
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1263 +/- ##
==========================================
+ Coverage 52.93% 53.43% +0.50%
==========================================
Files 462 462
Lines 26090 25850 -240
Branches 2419 2389 -30
==========================================
+ Hits 13810 13813 +3
+ Misses 12280 12037 -243 ☔ View full report in Codecov by Sentry. |
luishfonseca
force-pushed
the
465-port-to-web
branch
2 times, most recently
from
2503415 to
7b34b73
Compare
RiscadoA
force-pushed
the
465-port-to-web
branch
3 times, most recently
from
b6f5b1c to
c7c0259
Compare
luishfonseca
force-pushed
the
465-port-to-web
branch
2 times, most recently
from
31108c1 to
832c19b
Compare
RiscadoA
force-pushed
the
465-port-to-web
branch
from
832c19b to
1097fcb
Compare
luishfonseca
force-pushed
the
465-port-to-web
branch
from
1097fcb to
832c19b
Compare
RiscadoA
force-pushed
the
465-port-to-web
branch
from
832c19b to
15a4797
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
luishfonseca
force-pushed
the
465-port-to-web
branch
from
15a4797 to
7ead7d7
Compare
…rs from its warnings
Necessary for glfwSwapInterval to work correctly
RiscadoA
force-pushed
the
465-port-to-web
branch
from
3f8c5ae to
5dca160
Compare
RiscadoA
force-pushed
the
465-port-to-web
branch
from
5dca160 to
7f38ef9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Edited by @RiscadoA)
This PR ended up being absolutely gigantic.
I think the best way to review it is to give a quick look at the commits we made. They are very granular and all do pretty much a single thing, which makes it easier to follow the 'story' of what we were doing.
Make sure to at least give a look at the parts of the code which you're more familiar with/you authored, and see if stuff makes sense to you.
Web support was implemented with Emscripten, which is basically a C++ compiler which targets javascript and wasm.
Instead of outputting executables, this outputs an html page for each executable, i.e., all samples and also tesseratos.
We had to change lots of tiny nitpicks to make this work, particularly, on the rendering side.
A lot of our code was incompatible with WebGL. We reduced the interface of RenderDevice to contain only the interface supported by both OpenGL and WebGL.
We also added an action to build it here on GitHub. That action uploads the resulting artifacts, which you can download and try running on your machine. On a future PR we should improve this to automatically place the samples in their respective documentation pages. Will create issues for that soon
Checklist